[QA] Fixing flaky test - TC: SALEOR_205 Bulk delete customers #4857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃 Changeset detectedLatest commit: c5ba86c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yellowee
changed the title
yellowee
force-pushed
the
fixing_flaky_bulk_delete_customers_test_e2e
branch
from
fa70f38
to
4dddd70
Compare
yellowee
force-pushed
the
fixing_flaky_bulk_delete_customers_test_e2e
branch
from
899f092
to
24f3582
Compare
yellowee
force-pushed
the
fixing_flaky_bulk_delete_customers_test_e2e
branch
from
24f3582
to
c5ba86c
Compare
karola312
approved these changes
May 15, 2024
yellowee
requested review from
Cloud11PL
and removed request for
witoszekdev and
krzysztofzuraw
Cloud11PL
approved these changes
May 15, 2024
Comment on lines
+54
to
+55
| await this.loader.waitFor({ state: "hidden" }); | ||
| await this.giftCardDialog.waitFor({ state: "visible" }); |
There was a problem hiding this comment.
Suggestion: It seems like it would be a fit for a separate function as apart from clicking the button it also checks for modal mount
karola312
pushed a commit
that referenced
this pull request
May 23, 2024
* Fixing flaky test - TC: SALEOR_205 Bulk delete customers * fixing flaky gift card tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description