Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Adding support for audio files #518

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Lucas-C
Copy link
Contributor

@Lucas-C Lucas-C commented May 6, 2024

Implementation for the feature requested in #141

This is currently a draft: the server-side part is OK I think, but it seems like some themes do not support audio files...

Some other things are also currently missing:

  • unit tests
  • ensure that audio_file.png is properly embedded in the package published on Pypi

Note: the audio_file.png comes from Wikimedia / the Noun project -> https://commons.wikimedia.org/wiki/File:Audio_file_%2861746%29_-_The_Noun_Project.svg

@Lucas-C Lucas-C force-pushed the support-audio-files branch 4 times, most recently from d370cf6 to b6d2ccb Compare May 6, 2024 15:03
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 48.71795% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 87.80%. Comparing base (cf15fcc) to head (56379a1).

Files Patch % Lines
src/sigal/gallery.py 42.10% 11 Missing ⚠️
src/sigal/audio.py 45.45% 6 Missing ⚠️
src/sigal/utils.py 71.42% 2 Missing ⚠️
src/sigal/settings.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
- Coverage   88.54%   87.80%   -0.74%     
==========================================
  Files          25       26       +1     
  Lines        2077     2115      +38     
==========================================
+ Hits         1839     1857      +18     
- Misses        238      258      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lucas-C Lucas-C mentioned this pull request May 6, 2024
@Lucas-C Lucas-C force-pushed the support-audio-files branch from b6d2ccb to 56379a1 Compare May 6, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant