Add aria-multiselectable #1726
Add aria-multiselectable #1726
Conversation
👷 Deploy request for vueselect accepted.
|
|
If you could add a test for the attribute value here we can get this one released. Thanks for the efforts! |
Pytal
force-pushed
the
enh/a11y-aria-multiselectable
branch
from
e082b2c to
3d17871
Compare
|
Tests added! |
src/components/Select.vue
Outdated
| if (this.multiple) { | ||
| return this.isOptionSelected(option) | ||
| } | ||
| return index === this.typeAheadPointer ? true : null |
There was a problem hiding this comment.
I think my original functionality here was actually incorrect. I was using aria-selected to denote that the option is currently highlighted, but after rereading the docs, it should be used to denote the current selection. I think it should probably be this.isOptionSelected in all cases.
Let me know if you think I'm incorrect there.
There was a problem hiding this comment.
Agreed and updated!
Also converted the boolean to string to match the docs https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-selected#values (otherwise false would omit the attr and make it seem unselectable) with updated tests!
There was a problem hiding this comment.
Look good now @sagalbot?
Pytal
force-pushed
the
enh/a11y-aria-multiselectable
branch
2 times, most recently
from
b5f38fe to
882e42d
Compare
- Implemented as described in the MDN docs: - https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-multiselectable - https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-selected Signed-off-by: Christopher Ng <[email protected]>
Pytal
force-pushed
the
enh/a11y-aria-multiselectable
branch
from
882e42d to
5e1fad0
Compare
|
Hi @sagalbot , |
Enhance component accessibiltiy as described in the MDN docs: