-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update header safe token widget for SAP [SW-586] #4565
base: dev
Are you sure you want to change the base?
Conversation
Branch preview✅ Deploy successful! Storybook: |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
1.01 MB (🟡 +259 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1620 tests passing in 217 suites. Report generated by 🧪jest coverage report action from d999b3f |
Can you insert a screenshot? In my safes, the widget looks the same as before. |
Added a screenshot to the description. The copy needs to be updated before we merge this so I would leave the PR open for now. |
Changed it so it only displays the update for safe owners |
LGMT |
@francovenica I will push another change to exclude the allocation of the new Airdrop as long as the start date has not been reached otherwise it is misleading to include this number since technically it is "vesting" but can't be claimed at all. |
Yes, the 10k number in the header widget is correct because the allocation for SAP has not started yet. I will also update the number in the governance app so it will say "Total voting power is 10k" in this case. |
What it solves
Resolves SW-586
How this PR fixes it
UnreadBadge
to the safe token header widget in case there is an allocationHow to test it
Screenshots
Checklist