Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade transactions for 1.0.0 Safes #4460

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Nov 1, 2024

What it solves

Upgrade transactions for 1.0.0 Safes included an empty transaction instead of the setFallbackHandler call.

How this PR fixes it

Uses the Safe contract interface of the upgraded Safe's version instead of the current Safe's version.
This is correct as we first upgrade and change the masterCopy and then set the FallbackHandler.

How to test it

  • Create a 1.0.0 Safe on e.g. Gnosis Chain
  • Upgrade it to 1.4.1 through our interface

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Nov 1, 2024

@schmanu schmanu requested a review from iamacook November 1, 2024 16:15
Copy link

Copy link

github-actions bot commented Nov 1, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Nov 1, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.07% (-0% 🔻)
13902/18768
🔴 Branches
52.69% (-0.02% 🔻)
3423/6496
🔴 Functions 57.92% 2029/3503
🟡 Lines
75.75% (-0% 🔻)
12631/16675
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / safeUpdateParams.ts
95.24% (-4.76% 🔻)
0% (-100% 🔻)
100%
95% (-5% 🔻)

Test suite run success

1593 tests passing in 215 suites.

Report generated by 🧪jest coverage report action from 045c7d5

Co-authored-by: Aaron Cook <[email protected]>
@liliya-soroka
Copy link
Member

Verified:
checked mastercopies:
1.1.1
1.0.0

@iamacook iamacook merged commit cff8b41 into dev Dec 10, 2024
15 checks passed
@iamacook iamacook deleted the fix/upgrade-1.0.0-safes branch December 10, 2024 09:08
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants