fix: upgrade transactions for 1.0.0 Safes #4460
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Upgrade transactions for 1.0.0 Safes included an empty transaction instead of the
setFallbackHandler
call.How this PR fixes it
Uses the Safe contract interface of the upgraded Safe's version instead of the current Safe's version.
This is correct as we first upgrade and change the masterCopy and then set the FallbackHandler.
How to test it
Checklist