RPC Taken from ethereum-lists directly
#873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
reviewed
Nov 21, 2024
bin/github-review.sh
Outdated
| @@ -45,9 +45,9 @@ if [[ -z $chainid ]]; then | |||
| echo "ERROR: Chain ID not specified as per the PR Template" 1>&2 | |||
| exit 1 | |||
| fi | |||
| rpc="$(gh pr view $pr | sed -nE 's|^- RPC_URL: (https?://[^ ]+).*$|\1|p')" | |||
| rpc="$(gh api -H "Accept: application/vnd.github+json" -H "X-GitHub-Api-Version: 2022-11-28" /repos/ethereum-lists/chains/contents/_data/chains/eip155-$chainid.json | jq -r .content | base64 --decode | jq -r '.rpc[0]')" | |||
There was a problem hiding this comment.
nit: this shouldn't use GitHub API IMO - we can just curl the file directly:
chainlisturl="https://raw.githubusercontent.com/ethereum-lists/chains/refs/heads/master/_data/chains/eip155-$chainid.json"
rpc="$(curl -sfL "$chainlisturl" | jq -r '.rpc[0]')"
nlordell
reviewed
Nov 21, 2024
nlordell
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved #688
This pull request includes a small but significant change to the
.github/PULL_REQUEST_TEMPLATE.mdfile. The change updates the instructions for adding a new chain by specifying that the RPC URL will be taken from theethereum-lists/chainsrepository..github/PULL_REQUEST_TEMPLATE.md: Updated the instructions to clarify that the RPC URL will be sourced from theethereum-lists/chainsrepository.bin/github-review.sh: Updated how RPC is fetched (Before: from PR description. After: fromethereum-lists).