Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 1.4.1 contracts for DuckChain EVM Mainnet #850

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cppfuns
Copy link

@cppfuns cppfuns commented Oct 30, 2024

Add new chain

Please fill the following form:

Provide the Chain ID (Only 1 chain id per PR).

  • Chain_ID: 5545

Provide RPC URL for the chain (should be able to query atleast 3+ requests per second for automatic PR check).

Relevant information:
Add any other relevant information like blockexplorer, any annotation...

safe-singleton-factory issue: safe-global/safe-singleton-factory#747
block explorer: https://scan.duckchain.io/

@cppfuns cppfuns requested review from gjeanmart and a team as code owners October 30, 2024 02:44
@remedcu
Copy link
Member

remedcu commented Oct 31, 2024

Looks like the contract was not deployed correctly. Could you check if the deployment was done correctly?

@cppfuns
Copy link
Author

cppfuns commented Nov 4, 2024

Looks like the contract was not deployed correctly. Could you check if the deployment was done correctly?

I followed the process and the contract was automatically deployed by Safe, so what am I not understanding?

safe-global/safe-singleton-factory#747
https://scan.duckchain.io/address/0x914d7Fec6aaC8cd542e72Bca78B30650d45643d7?tab=contract

@remedcu
Copy link
Member

remedcu commented Nov 4, 2024

That was the singleton factory deployment, which is used to deploy contracts to deterministic addresses. To deploy the safe contracts, you can follow this: https://github.com/safe-global/safe-smart-account?tab=readme-ov-file#deploy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants