Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Japan Open Chain Testnet #308

Merged
merged 1 commit into from
Oct 30, 2023
Merged

feat: Add Japan Open Chain Testnet #308

merged 1 commit into from
Oct 30, 2023

Conversation

0xcuonghx
Copy link
Contributor

Fixed #307

@0xcuonghx 0xcuonghx requested review from a team as code owners October 24, 2023 04:01
mmv08
mmv08 reviewed Oct 24, 2023
View reviewed changes
src/assets/v1.3.0/gnosis_safe_l2.json Outdated
@@ -105,6 +105,7 @@
"9728": "0xfb1bffC9d739B8D520DaF37dF666da4C687191EA",
"10000": "0xfb1bffC9d739B8D520DaF37dF666da4C687191EA",
"10001": "0xfb1bffC9d739B8D520DaF37dF666da4C687191EA",
"10081": "0xB19D6FFc2182150F8Eb585b79D4ABcd7C5640A9d",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to match the expect address

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mmv08 Thank you for your reviewing. I've already update it

@mmv08 mmv08 merged commit cbdc21c into safe-global:main Oct 30, 2023
1 check passed
@mmv08 mmv08 mentioned this pull request Oct 30, 2023
Merged
@0xcuonghx 0xcuonghx mentioned this pull request Nov 1, 2023
Merged
@0xcuonghx 0xcuonghx mentioned this pull request Oct 15, 2024
Merged
remedcu pushed a commit that referenced this pull request Oct 15, 2024
@0xcuonghx
Add contracts v1.4.1 to Japan Open Chain Testnet (#824)
9076b90 
## Add new chain

> Template to provide information about the new chain. Only add extra
information in the bottom section. Ensure that the contracts are
deployed on the chain, if not deploy with
[safe-contracts](https://github.com/safe-global/safe-contracts). Only
**one** chain ID, **one** Safe version and **one** deployment type per
PR. This entire paragraph should be deleted.

Please fill the following form:

Provide the Chain ID (Only 1 chain id per PR).
- Chain_ID: 10081

Provide RPC URL for the chain (should be able to query atleast 10
requests per minute for automatic PR check).
- RPC_URL: https://rpc-1.testnet.japanopenchain.org:8545

Relevant information:
Add any other relevant information like blockexplorer, any annotation...
Fixed #821 
Blockexplorer: https://explorer.testnet.japanopenchain.org/
Merged PRs for v1.3.0:
#308

---------

Co-authored-by: cuonghx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmv08 mmv08 mmv08 approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner rmeissner is a code owner automatically assigned from safe-global/safe-protocol

@nlordell nlordell Awaiting requested review from nlordell nlordell is a code owner automatically assigned from safe-global/safe-protocol

@Uxio0 Uxio0 Awaiting requested review from Uxio0 Uxio0 is a code owner automatically assigned from safe-global/safe-protocol

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

@moisses89 moisses89 Awaiting requested review from moisses89 moisses89 was automatically assigned from safe-global/safe-services

@hectorgomezv hectorgomezv Awaiting requested review from hectorgomezv hectorgomezv was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New chain]: Japan Open Chain Testnet
2 participants
@0xcuonghx @mmv08