Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set limit explicitly to 100 #94

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Apr 2, 2024

Bug description

  • the default limit is 20
  • We based our page calculation on the limit being 100 though

What this PR changes

  • explicitly sets limit to 100

@schmanu schmanu requested a review from jmealy April 2, 2024 15:34
Copy link

github-actions bot commented Apr 2, 2024

Branch preview

✅ Deploy successful!

https://fix_history_limit--governance.review-react-br.5afe.dev

Copy link

github-actions bot commented Apr 2, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@schmanu schmanu requested a review from katspaugh April 3, 2024 13:34
@liliya-soroka
Copy link
Member

checked. Looks correct now on UI - both graph and locked amount

@schmanu schmanu merged commit b3ae55b into token-locking Apr 4, 2024
5 checks passed
@schmanu schmanu deleted the fix-history-limit branch April 4, 2024 13:25
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants