Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: dynamic states for boost breakdown and boost meter #85

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Mar 27, 2024

What this PR changes

  • add empty state for boost breakdown
  • change text and color of boost meter depending on state

Screenshots

Screenshot 2024-03-27 at 16 27 52
Screenshot 2024-03-27 at 16 27 16

@schmanu schmanu changed the base branch from dev to token-locking March 27, 2024 15:30
Copy link

github-actions bot commented Mar 27, 2024

Branch preview

✅ Deploy successful!

https://feat_empty_boostbreakdown--governance.review-react-br.5afe.dev

Copy link

github-actions bot commented Mar 27, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@schmanu schmanu requested a review from usame-algan March 27, 2024 15:43
Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The number moved up a bit but I think it should be at the bottom of the window.

Screenshot 2024-03-27 at 17 58 12

if (isVisibleDifference && prediction) {
boostMeterInfo = (
<Typography>
If you lock in 10 days your boost will be only{' '}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you lock in 10 days your boost will be only{' '}
If you lock in 10 days your boost will only be{' '}

@schmanu schmanu merged commit 0f3e455 into token-locking Mar 28, 2024
5 checks passed
@schmanu schmanu deleted the feat/empty-boostbreakdown branch March 28, 2024 09:11
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants