Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: analytics through safe-apps-sdk #80

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Mar 26, 2024

What is this PR about

  • adds trackSafeAppEvent tool
  • add lock, withdraw and unlock events

We will add full / more event coverage in follow-up PRs.

TODOs

  • Once the new deployment URL is decided on, we have to allow list that URL in the wallet interface

@schmanu schmanu requested a review from usame-algan March 26, 2024 17:36
Copy link

github-actions bot commented Mar 26, 2024

Branch preview

✅ Deploy successful!

https://feat_analytics--governance.review-react-br.5afe.dev

Copy link

github-actions bot commented Mar 26, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to add the governance safe app url to the ALLOWED_DOMAINS in safe-wallet-web in order for the events to be propagated. Just saw it in the PR description :)

@schmanu schmanu requested a review from usame-algan March 27, 2024 14:37
Comment on lines 41 to 43
<Box display="flex" alignItems="center">
<Box>Unlock/Withdraw</Box>
</Box>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated but we probably don't need these 2 Box elements here.

@schmanu schmanu merged commit bb980cd into token-locking Mar 28, 2024
5 checks passed
@schmanu schmanu deleted the feat/analytics branch March 28, 2024 08:44
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants