-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epic: Token locking #57
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
Co-authored-by: schmanu <[email protected]>
Co-authored-by: schmanu <[email protected]>
Co-authored-by: Manuel Gellfart <[email protected]>
Co-authored-by: Manuel Gellfart <[email protected]>
…e-dao-governance-app into feat/unlock-copy-changes
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor nits. Looks good otherwise!
src/hooks/useSafeTokenBalance.ts
Outdated
export type SingleUnlock = { | ||
unlockAmount: BigNumber | ||
unlockedAt: BigNumber | ||
isUnlocked: boolean | ||
} | ||
|
||
export const useSafeTokenLockUserInfo = () => { | ||
const QUERY_KEY = 'safe-token-locked' | ||
const web3 = useWeb3() | ||
const chainId = useChainId() | ||
const address = useAddress() | ||
|
||
return useSWR(web3 && address ? QUERY_KEY : null, (): Promise<[BigNumber, BigNumber, number, number] | undefined> => { | ||
if (!address || !web3) { | ||
return Promise.resolve([BigNumber.from(0), BigNumber.from(0), 0, 0]) | ||
} | ||
return fetchLockedAmount(chainId, address, web3) | ||
}) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is unused
src/utils/lock.ts
Outdated
* @param index index of the unlock | ||
* @returns Unlock data for index: [amount, unlockedAt (in seconds)] or undefined | ||
*/ | ||
export const fetchUnlockData = async ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also seems unused
What this epic is about
This epic transforms the Safe DAO governance app into the Safe {Pass} | {DAO} app.
Overall the app is split in 2 parts:
While the second remains mostly the same the Activity & Rewards page is completely new.
It offers
The Activity & Rewards part of the app is usable as Safe App and via WalletConnect as a standalone application.