feat: dynamic campaign promotions #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview⏳ Deploying a preview site... |
usame-algan
reviewed
Sep 18, 2024
Comment on lines
118
to
120
| color: '#2470FF', | ||
| '&:hover': { | ||
| backgroundColor: ({ palette }) => `rgba(36, 112, 255, ${palette.action.hoverOpacity})`, |
There was a problem hiding this comment.
This blue color still belongs to one specific campaign or is it the same for every campaign?
There was a problem hiding this comment.
Its the same on every campaign. There is no configurable color atm. So we could change it but only to a constant other color.
cc @TanyaEfremova
There was a problem hiding this comment.
I changed all colors and styles according to the new designs:
usame-algan
reviewed
Sep 18, 2024
| @@ -45,7 +50,7 @@ export const CampaignPromo = () => { | |||
| <LinearProgress | |||
| className={css.progressBar} | |||
| variant="determinate" | |||
| value={progress} | |||
| value={progress * 100} | |||
There was a problem hiding this comment.
Did something change about the progress value so that we have to multiply it now?
There was a problem hiding this comment.
It was wrong before but noone realized it. It has to be between 0 and 100 and not 0 and 1
usame-algan
approved these changes
Sep 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes
CampaignPromoCampaignPromowith its valuesOther changes