Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show disclaimer as popup when opening partner links #200

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Aug 15, 2024

What this PR changes

  • Removes static collapsable disclaimer below Campaign info
  • Adds new disclaimer which is shown before opening a partner link the first time

@schmanu schmanu requested a review from usame-algan August 15, 2024 14:05
Copy link

github-actions bot commented Aug 15, 2024

Branch preview

✅ Deploy successful!

https://feat_disclaimer_popup--governance.review-react-br.5afe.dev

@schmanu schmanu requested a review from jmealy August 19, 2024 13:58
Copy link
Contributor

@jmealy jmealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small grammar mistakes in the text, otherwise looks good

src/components/DisclaimerLink/index.tsx Outdated Show resolved Hide resolved
src/components/DisclaimerLink/index.tsx Outdated Show resolved Hide resolved
src/components/DisclaimerLink/index.tsx Outdated Show resolved Hide resolved
src/components/DisclaimerLink/index.tsx Outdated Show resolved Hide resolved
Co-authored-by: James Mealy <[email protected]>
@schmanu schmanu requested a review from jmealy August 29, 2024 15:10
@schmanu schmanu merged commit 9c57b1a into dev Aug 30, 2024
3 of 4 checks passed
@schmanu schmanu deleted the feat/disclaimer-popup branch August 30, 2024 15:11
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants