Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: app icon url for wallet connect #159

Merged
merged 2 commits into from
Apr 22, 2024
Merged

fix: app icon url for wallet connect #159

merged 2 commits into from
Apr 22, 2024

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Apr 22, 2024 •
edited
Loading

What this PR fixes

  • When wallet connect establishes a connection it could not find the app's icon and showed a placeholder

Screenshot

Screenshot 2024-04-22 at 13 53 27

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited
Loading

Branch preview

✅ Deploy successful!

https://fix_wallet_connect_dapp_icon--governance.review-react-br.5afe.dev

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@schmanu schmanu requested a review from jmealy April 22, 2024 11:54
@schmanu schmanu merged commit 3ad6a3b into dev Apr 22, 2024
5 checks passed
@schmanu schmanu deleted the fix/wallet-connect-dapp-icon branch April 22, 2024 12:42
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmealy jmealy jmealy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schmanu @jmealy