Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: rounding in BoostCounter #109

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Fix: rounding in BoostCounter #109

merged 2 commits into from
Apr 8, 2024

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Apr 8, 2024

What this PR changes

  • Instead of rounding the number we just slice it in BoostCounter to avoid rounding issues caused by incorrect floating point math.

@schmanu schmanu requested a review from jmealy April 8, 2024 13:37
Copy link

github-actions bot commented Apr 8, 2024

Branch preview

✅ Deploy successful!

https://fix_rounding--governance.review-react-br.5afe.dev

Copy link

github-actions bot commented Apr 8, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@schmanu schmanu merged commit 02f26f9 into token-locking Apr 8, 2024
5 checks passed
@schmanu schmanu deleted the fix/rounding branch April 8, 2024 14:53
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants