Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: adjust right sidebar #105

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Feat: adjust right sidebar #105

merged 3 commits into from
Apr 9, 2024

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Apr 8, 2024

What this PR changes

  • Moved T&C link to sidebar
  • Removes dates from sidebar
  • Removes lottery

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024 •
edited
Loading

Branch preview

✅ Deploy successful!

https://feat_adjust_content--governance.review-react-br.5afe.dev

@schmanu schmanu requested a review from jmealy April 8, 2024 09:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

jmealy
jmealy requested changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@jmealy jmealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links are spilling out of the sidebar:

image

@schmanu
Copy link
Member Author

schmanu commented Apr 8, 2024

The links are spilling out of the sidebar:
image

@jmealy The links are like this in the figma designs.
The T&C link is supposed to be outside: https://www.figma.com/file/Q4tCvL7994RIx3SjNUXYjH/Safe-Activity-App?node-id=1088%3A10025

@schmanu schmanu requested a review from jmealy April 8, 2024 15:47
@schmanu schmanu merged commit 7dfd4ac into token-locking Apr 9, 2024
5 checks passed
@schmanu schmanu deleted the feat/adjust-content branch April 9, 2024 11:00
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmealy jmealy jmealy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schmanu @jmealy