-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the nest-js-core group with 4 updates #2277
base: main
Are you sure you want to change the base?
Conversation
c1ed76e
to
19ed08c
Compare
Bumps the nest-js-core group with 4 updates: [@nestjs/common](https://github.com/nestjs/nest/tree/HEAD/packages/common), [@nestjs/core](https://github.com/nestjs/nest/tree/HEAD/packages/core), [@nestjs/platform-express](https://github.com/nestjs/nest/tree/HEAD/packages/platform-express) and [@nestjs/testing](https://github.com/nestjs/nest/tree/HEAD/packages/testing). Updates `@nestjs/common` from 10.4.15 to 11.0.3 - [Release notes](https://github.com/nestjs/nest/releases) - [Commits](https://github.com/nestjs/nest/commits/v11.0.3/packages/common) Updates `@nestjs/core` from 10.4.15 to 11.0.3 - [Release notes](https://github.com/nestjs/nest/releases) - [Commits](https://github.com/nestjs/nest/commits/v11.0.3/packages/core) Updates `@nestjs/platform-express` from 10.4.15 to 11.0.3 - [Release notes](https://github.com/nestjs/nest/releases) - [Commits](https://github.com/nestjs/nest/commits/v11.0.3/packages/platform-express) Updates `@nestjs/testing` from 10.4.15 to 11.0.3 - [Release notes](https://github.com/nestjs/nest/releases) - [Commits](https://github.com/nestjs/nest/commits/v11.0.3/packages/testing) --- updated-dependencies: - dependency-name: "@nestjs/common" dependency-type: direct:production update-type: version-update:semver-major dependency-group: nest-js-core - dependency-name: "@nestjs/core" dependency-type: direct:production update-type: version-update:semver-major dependency-group: nest-js-core - dependency-name: "@nestjs/platform-express" dependency-type: direct:production update-type: version-update:semver-major dependency-group: nest-js-core - dependency-name: "@nestjs/testing" dependency-type: direct:development update-type: version-update:semver-major dependency-group: nest-js-core ... Signed-off-by: dependabot[bot] <[email protected]>
19ed08c
to
b3b6b59
Compare
"@nestjs/schedule": "^4.1.2", | ||
"@nestjs/serve-static": "^4.0.2", | ||
"@nestjs/serve-static": "^5.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update this here as the package otherwise prevents startup. Internally, it has an unexpected *
path, which goes against the new path-to-regexp requirements. This stems from Express v5.
@@ -129,7 +129,7 @@ export class AppModule implements NestModule { | |||
// Excludes the paths under '/' (base url) from being served as static content | |||
// If we do not exclude these paths, the service will try to find the file and | |||
// return 500 for files that do not exist instead of a 404 | |||
exclude: ['/(.*)'], | |||
exclude: ['{*any}'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The excluded paths are passed to path-to-regexp, which no longer accepts certain unexpected characters. This stems from Express v5.
@@ -181,6 +181,6 @@ export class AppModule implements NestModule { | |||
// The ClsMiddleware needs to be applied before the LoggerMiddleware | |||
// in order to generate the request ids that will be logged afterward | |||
.apply(ClsMiddleware, NotFoundLoggerMiddleware) | |||
.forRoutes({ path: '*', method: RequestMethod.ALL }); | |||
.forRoutes({ path: '{*any}', method: RequestMethod.ALL }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
path-to-regexp no longer accpets unexpected *
paths. This stems from Express v5.
@@ -58,6 +59,10 @@ export const DEFAULT_CONFIGURATION: Array<(app: INestApplication) => void> = [ | |||
configureCookies, | |||
]; | |||
|
|||
// Not exported outside {@link NestFactoryStatic} as of v11.0.3 | |||
// @see https://github.com/nestjs/nest/blob/bab9ed65e8d33d3304204e5c1ed0c74e2b5a90b5/packages/core/nest-factory.ts#L33 | |||
export type IEntryNestModule = Parameters<NestFactoryStatic['create']>[0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not exported.
Bumps the nest-js-core group with 4 updates: @nestjs/common, @nestjs/core, @nestjs/platform-express and @nestjs/testing.
Updates
@nestjs/common
from 10.4.15 to 11.0.3Release notes
Sourced from
@nestjs/common
's releases.... (truncated)
Commits
cbebdd2
chore(@nestjs
) publish v11.0.3 releasefca5ebb
chore(@nestjs
) publish v11.0.2 release0f617d4
chore(@nestjs
) publish v11.0.1 release1299888
chore: update readmee19b586
chore(@nestjs
) publish v11.0.0 releasedb2a9b5
chore: resolve conflicts9e5f77c
chore: resolve conflicts8bcd1e5
chore: resolve conflicts9267472
chore: update copyright years 2025c82c342
fix: redirect the path of file to correct pathUpdates
@nestjs/core
from 10.4.15 to 11.0.3Release notes
Sourced from
@nestjs/core
's releases.... (truncated)
Commits
cbebdd2
chore(@nestjs
) publish v11.0.3 releasefca5ebb
chore(@nestjs
) publish v11.0.2 release0f617d4
chore(@nestjs
) publish v11.0.1 released6b9fee
fix: normalize middle wildcards, call path-to-regexp early1299888
chore: update readmee19b586
chore(@nestjs
) publish v11.0.0 release95654f9
chore: update package.json6791b6c
style: address lint errorsdb2a9b5
chore: resolve conflictsa24ef96
chore(deps): Update opencollective to 0.4.1 under new scopeUpdates
@nestjs/platform-express
from 10.4.15 to 11.0.3Release notes
Sourced from
@nestjs/platform-express
's releases.... (truncated)
Commits
cbebdd2
chore(@nestjs
) publish v11.0.3 release5eaae5f
fix(platform): add missing path-to-regexp dependency #14461fca5ebb
chore(@nestjs
) publish v11.0.2 release9aa2a43
fix: use express body-parser reexports0f617d4
chore(@nestjs
) publish v11.0.1 released6b9fee
fix: normalize middle wildcards, call path-to-regexp early1299888
chore: update readmee19b586
chore(@nestjs
) publish v11.0.0 release224e0dd
chore: upgrade multer95654f9
chore: update package.jsonUpdates
@nestjs/testing
from 10.4.15 to 11.0.3Release notes
Sourced from
@nestjs/testing
's releases.... (truncated)
Commits
cbebdd2
chore(@nestjs
) publish v11.0.3 releasefca5ebb
chore(@nestjs
) publish v11.0.2 release65cfe0c
refactor: pick only one option attribute for test module817ede3
fix: Module id generatorAlgorithm can't be controlled in test #144550f617d4
chore(@nestjs
) publish v11.0.1 release1299888
chore: update readmee19b586
chore(@nestjs
) publish v11.0.0 release95654f9
chore: update package.json9e5f77c
chore: resolve conflicts8bcd1e5
chore: resolve conflictsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions