Add demonstrative DeduplicationInterceptor to reduce duplicate requests
#2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
commented
Dec 11, 2024
| expect(testService.fetchData).toHaveBeenCalledTimes(2); | ||
| }); | ||
|
|
||
| it.todo('test all variations of registry key'); |
There was a problem hiding this comment.
Should we approve of the implementation, these tests will be expanded.
iamacook
commented
Dec 11, 2024
| }); | ||
|
|
||
| it('should handle different requests separately', async () => { | ||
| (testService.fetchData as jest.Mock).mockClear(); |
There was a problem hiding this comment.
I'll align this more with our mocking approach should be move foward with it.
iamacook
commented
Dec 11, 2024
| @@ -160,6 +161,10 @@ export class AppModule implements NestModule { | |||
| provide: APP_INTERCEPTOR, | |||
| useClass: CacheControlInterceptor, | |||
| }, | |||
| { | |||
| provide: APP_INTERCEPTOR, | |||
There was a problem hiding this comment.
This might need be localised to datasources, otherwise different calls to datasources within a mapping might still make separate requests.
There was a problem hiding this comment.
I've just experimented some more and this is indeed the case.
|
I've since learnt that inteceptors are controller-focused. As such, we'd need take another approach. As such, I'm going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ideates on #2181 and our previous (reverted) promise registry implementation.
Due to the async nature of the project, services can send several requests of the same requests in parallel. Only after one of these succeeds is the result cached.
This implements an interceptor which registers each
Requestpromise in a registry. Should a subsequentRequesthappen and the aforementioned registration exist, it is returned instead of making a parallel one.Changes
DeduplicationInterceptorin the app