Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't create DataSourceErrors from ZodErrors in SafeBalancesApi #2174

Closed
wants to merge 1 commit into from
Closed

Don't create DataSourceErrors from ZodErrors in SafeBalancesApi #2174

wants to merge 1 commit into from

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Dec 4, 2024

Summary

Similarly to #2166, we are traversing between Raw<T> and T within the IBalancesApi by validating instead of casting.

The ZerionBalancesApi was adjusted to not convert ZodErrors to DataSourceErrors. This makes the same adjustment for the SafeBalancesApi.

Changes

  • Don't wrap ZodErrors as DataSourceErrors

@iamacook iamacook self-assigned this Dec 4, 2024
@iamacook iamacook requested a review from a team as a code owner December 4, 2024 16:09
@iamacook
Copy link
Member Author

iamacook commented Dec 4, 2024

To save exposing a 500, I am moving these changes into the PR which this supports.

@iamacook iamacook closed this Dec 4, 2024
@iamacook iamacook mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@iamacook iamacook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iamacook