Return 502 for gateway validation errors

src/domain/safe/entities/__tests__/module-transaction.builder.ts

@@ -18,7 +18,7 @@ export function moduleTransactionBuilder(): IBuilder<ModuleTransaction> {
     .with('safe', getAddress(faker.finance.ethereumAddress()))
     .with('to', getAddress(faker.finance.ethereumAddress()))
     .with('transactionHash', faker.string.hexadecimal() as `0x${string}`)
-    .with('value', faker.string.hexadecimal())
+    .with('value', faker.string.numeric())
     .with('moduleTransactionId', faker.string.sample());
 }
 

src/domain/safe/entities/__tests__/multisig-transaction.builder.ts

@@ -26,11 +26,11 @@ export function multisigTransactionBuilder(): IBuilder<MultisigTransaction> {
       .with('confirmationsRequired', faker.number.int())
       .with('data', faker.string.hexadecimal() as `0x${string}`)
       .with('dataDecoded', dataDecodedBuilder().build())
-      .with('ethGasPrice', faker.string.hexadecimal())
+      .with('ethGasPrice', faker.string.numeric())
       .with('executor', getAddress(faker.finance.ethereumAddress()))
       .with('executionDate', faker.date.recent())
-      .with('fee', faker.string.hexadecimal())
-      .with('gasPrice', faker.string.hexadecimal())
+      .with('fee', faker.string.numeric())
+      .with('gasPrice', faker.string.numeric())
       .with('gasToken', getAddress(faker.finance.ethereumAddress()))
       .with('gasUsed', faker.number.int())
       .with('isExecuted', faker.datatype.boolean())

src/routes/balances/balances.controller.spec.ts

@@ -800,7 +800,7 @@ describe('Balances Controller (Unit)', () => {
       });
     });
 
-    it(`500 error if validation fails`, async () => {
+    it(`502 error if validation fails`, async () => {
       const chainId = '1';
       const safeAddress = getAddress(faker.finance.ethereumAddress());
       const chainResponse = chainBuilder().with('chainId', chainId).build();
@@ -830,10 +830,10 @@ describe('Balances Controller (Unit)', () => {
 
       await request(app.getHttpServer())
         .get(`/v1/chains/${chainId}/safes/${safeAddress}/balances/usd`)
-        .expect(500)
+        .expect(502)
         .expect({
-          statusCode: 500,
-          message: 'Internal server error',
+          statusCode: 502,
+          message: 'Bad gateway',
         });
 
       expect(networkService.get.mock.calls.length).toBe(4);

src/routes/chains/chains.controller.spec.ts

@@ -299,10 +299,10 @@ describe('Chains Controller (Unit)', () => {
         status: 200,
       });
 
-      await request(app.getHttpServer()).get('/v1/chains').expect(500).expect({
-        statusCode: 500,
-        message: 'Internal server error',
-      });
+      await request(app.getHttpServer())
+        .get('/v1/chains')
+        .expect(502)
+        .expect({ statusCode: 502, message: 'Bad gateway' });
       expect(networkService.get).toHaveBeenCalledTimes(1);
       expect(networkService.get).toHaveBeenCalledWith({
         url: `${safeConfigUrl}/api/v1/chains`,
@@ -439,11 +439,8 @@ describe('Chains Controller (Unit)', () => {
 
       await request(app.getHttpServer())
         .get('/v1/chains/1/about/backbone')
-        .expect(500)
-        .expect({
-          statusCode: 500,
-          message: 'Internal server error',
-        });
+        .expect(502)
+        .expect({ statusCode: 502, message: 'Bad gateway' });
 
       expect(networkService.get).toHaveBeenCalledTimes(2);
       expect(networkService.get.mock.calls[0][0].url).toBe(
@@ -628,11 +625,8 @@ describe('Chains Controller (Unit)', () => {
 
       await request(app.getHttpServer())
         .get('/v1/chains/1/about/master-copies')
-        .expect(500)
-        .expect({
-          statusCode: 500,
-          message: 'Internal server error',
-        });
+        .expect(502)
+        .expect({ statusCode: 502, message: 'Bad gateway' });
     });
   });
 
@@ -761,11 +755,8 @@ describe('Chains Controller (Unit)', () => {
 
       await request(app.getHttpServer())
         .get(`/v1/chains/${chainResponse.chainId}/about/indexing`)
-        .expect(500)
-        .expect({
-          statusCode: 500,
-          message: 'Internal server error',
-        });
+        .expect(502)
+        .expect({ statusCode: 502, message: 'Bad gateway' });
     });
   });
 

src/routes/common/filters/zod-error.filter.spec.ts

@@ -55,6 +55,11 @@ class TestController {
     return body;
   }
 
+  @Post('zod-standard')
+  zodStandardError(): number {
+    return z.number().parse('string');
+  }
+
   @Get('non-zod-exception')
   nonZodException(): void {
     throw new Error('Some random error');
@@ -84,7 +89,7 @@ describe('ZodErrorFilter tests', () => {
     await app.close();
   });
 
-  it('ZodError exception returns first issue', async () => {
+  it('ZodErrorWithCode exception returns first issue', async () => {
     await request(app.getHttpServer())
       .post('/zod-exception')
       .send({ value: faker.number.int() })
@@ -99,7 +104,7 @@ describe('ZodErrorFilter tests', () => {
       });
   });
 
-  it('ZodError union exception returns first issue of first union issue', async () => {
+  it('ZodErrorWithCode union exception returns first issue of first union issue', async () => {
     await request(app.getHttpServer())
       .post('/zod-union-exception')
       .send({ value: faker.datatype.boolean() })
@@ -114,7 +119,7 @@ describe('ZodErrorFilter tests', () => {
       });
   });
 
-  it('ZodError nested union exception returns first issue of nested union issue', async () => {
+  it('ZodErrorWithCode nested union exception returns first issue of nested union issue', async () => {
     await request(app.getHttpServer())
       .post('/zod-union-exception')
       .send({
@@ -133,7 +138,17 @@ describe('ZodErrorFilter tests', () => {
       });
   });
 
-  it('non-ZodError exception returns correct error code and message', async () => {
+  it('ZodError returns 502', async () => {
+    await request(app.getHttpServer())
+      .post('/zod-standard')
+      .expect(502)
+      .expect({
+        statusCode: 502,
+        message: 'Bad gateway',
+      });
+  });
+
+  it('non-ZodError/ZodErrorWithCode exception returns correct error code and message', async () => {
     await request(app.getHttpServer())
       .get('/non-zod-exception')
       .expect(500)

src/routes/common/filters/zod-error.filter.ts

@@ -14,7 +14,7 @@ import { ZodErrorWithCode } from '@/validation/pipes/validation.pipe';
  *
  * It builds a JSON payload which contains a code and a message.
  * The message is read from the initial {@link ZodIssue} and the code
- * from {@link ZodErrorWithCode.code} or 500 if {@link ZodError}.
+ * from {@link ZodErrorWithCode.code} or 502 if {@link ZodError}.
  */
 @Catch(ZodError, ZodErrorWithCode)
 export class ZodErrorFilter implements ExceptionFilter {
@@ -32,9 +32,9 @@ export class ZodErrorFilter implements ExceptionFilter {
       });
     } else {
       // Don't expose validation as it may contain sensitive data
-      response.status(HttpStatus.INTERNAL_SERVER_ERROR).json({
-        statusCode: HttpStatus.INTERNAL_SERVER_ERROR,
-        message: 'Internal server error',
+      response.status(HttpStatus.BAD_GATEWAY).json({
+        statusCode: HttpStatus.BAD_GATEWAY,
+        message: 'Bad gateway',
       });
     }
   }

src/routes/community/community.controller.spec.ts

@@ -132,11 +132,8 @@ describe('Community (Unit)', () => {
 
       await request(app.getHttpServer())
         .get(`/v1/community/campaigns`)
-        .expect(500)
-        .expect({
-          statusCode: 500,
-          message: 'Internal server error',
-        });
+        .expect(502)
+        .expect({ statusCode: 502, message: 'Bad gateway' });
     });
 
     it('should forward the pagination parameters', async () => {
@@ -246,11 +243,8 @@ describe('Community (Unit)', () => {
 
       await request(app.getHttpServer())
         .get(`/v1/community/campaigns/${invalidCampaign.resourceId}`)
-        .expect(500)
-        .expect({
-          statusCode: 500,
-          message: 'Internal server error',
-        });
+        .expect(502)
+        .expect({ statusCode: 502, message: 'Bad gateway' });
     });
 
     it('should forward an error from the service', async () => {
@@ -448,11 +442,8 @@ describe('Community (Unit)', () => {
         .get(
           `/v1/community/campaigns/${campaign.resourceId}/activities?holder=${holder}`,
         )
-        .expect(500)
-        .expect({
-          statusCode: 500,
-          message: 'Internal server error',
-        });
+        .expect(502)
+        .expect({ statusCode: 502, message: 'Bad gateway' });
     });
 
     it('should forward an error from the service', () => {
@@ -545,11 +536,8 @@ describe('Community (Unit)', () => {
 
       await request(app.getHttpServer())
         .get(`/v1/community/campaigns/${campaign.resourceId}/leaderboard`)
-        .expect(500)
-        .expect({
-          statusCode: 500,
-          message: 'Internal server error',
-        });
+        .expect(502)
+        .expect({ statusCode: 502, message: 'Bad gateway' });
     });
 
     it('should forward the pagination parameters', async () => {
@@ -680,11 +668,8 @@ describe('Community (Unit)', () => {
 
       await request(app.getHttpServer())
         .get(`/v1/community/campaigns/${resourceId}/leaderboard/${safeAddress}`)
-        .expect(500)
-        .expect({
-          statusCode: 500,
-          message: 'Internal server error',
-        });
+        .expect(502)
+        .expect({ statusCode: 502, message: 'Bad gateway' });
     });
 
     it('should forward an error from the service', async () => {
@@ -815,11 +800,8 @@ describe('Community (Unit)', () => {
 
       await request(app.getHttpServer())
         .get(`/v1/community/locking/leaderboard`)
-        .expect(500)
-        .expect({
-          statusCode: 500,
-          message: 'Internal server error',
-        });
+        .expect(502)
+        .expect({ statusCode: 502, message: 'Bad gateway' });
     });
 
     it('should forward an error from the service', async () => {
@@ -900,11 +882,8 @@ describe('Community (Unit)', () => {
 
       await request(app.getHttpServer())
         .get(`/v1/community/locking/${safeAddress}/rank`)
-        .expect(500)
-        .expect({
-          statusCode: 500,
-          message: 'Internal server error',
-        });
+        .expect(502)
+        .expect({ statusCode: 502, message: 'Bad gateway' });
     });
 
     it('should forward an error from the service', async () => {
@@ -1068,11 +1047,8 @@ describe('Community (Unit)', () => {
 
       await request(app.getHttpServer())
         .get(`/v1/community/locking/${safeAddress}/history`)
-        .expect(500)
-        .expect({
-          statusCode: 500,
-          message: 'Internal server error',
-        });
+        .expect(502)
+        .expect({ statusCode: 502, message: 'Bad gateway' });
     });
 
     it('should forward an error from the service', async () => {

src/routes/contracts/contracts.controller.spec.ts

@@ -145,11 +145,8 @@ describe('Contracts controller', () => {
 
       await request(app.getHttpServer())
         .get(`/v1/chains/${chain.chainId}/contracts/${contract.address}`)
-        .expect(500)
-        .expect({
-          statusCode: 500,
-          message: 'Internal server error',
-        });
+        .expect(502)
+        .expect({ statusCode: 502, message: 'Bad gateway' });
     });
   });
 });

src/routes/delegates/delegates.controller.spec.ts

@@ -120,11 +120,8 @@ describe('Delegates controller', () => {
 
       await request(app.getHttpServer())
         .get(`/v1/chains/${chain.chainId}/delegates?safe=${safe}`)
-        .expect(500)
-        .expect({
-          statusCode: 500,
-          message: 'Internal server error',
-        });
+        .expect(502)
+        .expect({ statusCode: 502, message: 'Bad gateway' });
     });
 
     it('Should return empty result', async () => {

src/routes/delegates/v2/delegates.v2.controller.spec.ts

@@ -128,11 +128,8 @@ describe('Delegates controller', () => {
 
       await request(app.getHttpServer())
         .get(`/v2/chains/${chain.chainId}/delegates?safe=${safe}`)
-        .expect(500)
-        .expect({
-          statusCode: 500,
-          message: 'Internal server error',
-        });
+        .expect(502)
+        .expect({ statusCode: 502, message: 'Bad gateway' });
     });
 
     it('should return empty result', async () => {

src/routes/estimations/estimations.controller.spec.ts

@@ -168,11 +168,8 @@ describe('Estimations Controller (Unit)', () => {
         data: faker.string.hexadecimal({ length: 32 }),
         operation: 0,
       })
-      .expect(500)
-      .expect({
-        statusCode: 500,
-        message: 'Internal server error',
-      });
+      .expect(502)
+      .expect({ statusCode: 502, message: 'Bad gateway' });
   });
 
   it('Should get a validation error', async () => {

src/routes/messages/messages.controller.spec.ts

@@ -491,8 +491,8 @@ describe('Messages controller', () => {
 
       await request(app.getHttpServer())
         .get(`/v1/chains/${chain.chainId}/safes/${safe.address}/messages`)
-        .expect(500)
-        .expect({ statusCode: 500, message: 'Internal server error' });
+        .expect(502)
+        .expect({ statusCode: 502, message: 'Bad gateway' });
     });
 
     it('should get a message with a date label', async () => {

src/routes/owners/owners.controller.spec.ts

@@ -188,11 +188,8 @@ describe('Owners Controller (Unit)', () => {
 
       await request(app.getHttpServer())
         .get(`/v1/chains/${chainId}/owners/${ownerAddress}/safes`)
-        .expect(500)
-        .expect({
-          statusCode: 500,
-          message: 'Internal server error',
-        });
+        .expect(502)
+        .expect({ statusCode: 502, message: 'Bad gateway' });
     });
   });
 
@@ -445,11 +442,8 @@ describe('Owners Controller (Unit)', () => {
 
       await request(app.getHttpServer())
         .get(`/v1/owners/${ownerAddress}/safes`)
-        .expect(500)
-        .expect({
-          statusCode: 500,
-          message: 'Internal server error',
-        });
+        .expect(502)
+        .expect({ statusCode: 502, message: 'Bad gateway' });
     });
   });
 });