Handle *_DELEGATE Transaction Service events
#2106
Conversation
|
This has now been resolved. |
| >, | ||
| ): Array<Promise<void>> { | ||
| if (!event.safeAddress) { | ||
| return []; |
There was a problem hiding this comment.
Could you elaborate on the case the event is not directly related to a Safe address? I'm not super sure of the this, but does this happen if the delegate is linked to a delegator, but not to a specific Safe? Is it therefore is linked to all the Safes the delegator owns? Maybe we should include a comment explaining the case, wdyt?
There was a problem hiding this comment.
I'm not entirely sure why or how this can happening but the event can potentially have no address according to the Transaction Service.
There was a problem hiding this comment.
Just to comment. Right now, it is possible to create a delegate for a delegator without a specific safe. In that case, the delegate user would be valid for all safes of the delegator user. If a specific safe is specified, it would only be valid for operations on that safe.
There was a problem hiding this comment.
Thanks guys! Then if I understood correctly, if the Safe address included in the event is null we would need to clear the cache for all the Safe addresses the delegator owns. Do you think this is correct? @iamacook @falvaradorodriguez? 🙂
There was a problem hiding this comment.
I'm merging this one as it is, and I'm opening a new ticket so we can handle that case separately: #2146
Summary
The Transaction Service now emits new
*_DELEGATEevents for creating, updating and deleting delegates:NEW_DELEGATEUPDATED_DELEGATEDELETED_DELEGATEThis adds the relevant validation and handling of the aforementioned, clearing the delegates cache accordingly.
Changes