Add transaction_hash
query to module-transactions
#1624
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For role-based execution on the Web, it is necessary to query for module transactions via transaction hash. This is possible directly via the Transaction Service as the
module-transactions
endpoint accepts thetransaction_hash
query. However, we do not expose this on the Gateway.As such, this add and forwards a
transaction_hash
query to themodule-transactions
endpoint.Note: the clients also split the
txId
to fetch themoduleId
of the transaction in question. We should ideally return this within theTransaction
entity so that they need not reference our constructed ID. This would be better tackled in #1613, however.Changes
transaction_hash
query tomodule-transactions
endpoint and propagate it to Transaction ServicetxHash
value to field of module transaction cache