Dataset selector dialog fix2 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...considering the initial value, and was thus always displaying an empty field (no text)
...run(), which already sets up a whole lot of neccesary stuff around to actually be able to browse and later open an N5-compatible container. The implemented way of using run() warrants that the GUI dialog is always opened (or an exception is thrown).
...is a busy-run type of waiter until the container is fully discovered and this dialog's tree is fully populated consequently. The waiting loop is based on the observation that the async discovering code enables and disables a "message bar" prior and after the discovery. So, the waiting monitors when the "message bar" diappears. SwingUtils cannot help here.
...commands its 'selectionDialog' to potentially uncollapse parts of its tree, and select (highlight) the item that matches the provided path. Before looking for the right tree item/node, the code needs to wait until the container is fully discovered and thus the tree is populated, and the wanted item could be thus found.
- renamed to "Open in Imagej" - is disabled if there's any tree item selected, or non-selectable items are clicked - ENTER key associated with the button
|
This is great, @xulman thanks! I'll merge this shortly - one change I will revert is to keep the button labeled "OK", the reason being that I re-use the dialog in n5-viewer and so "Open In ImageJ" would feel too specific. We could consider making the text customizable in the future though, if you think it's useful. |
|
Thank you for letting this be upstream, it makes the DnD Fiji life much easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
one extra commit left over from the previous PR (sorry for that!)
N5Importer.runWithDialog()to import N5-ish containers always through the GUI dialog.the dialog can select/highlight an item at its opening
the dialog enables/disables 'OK' button based on its availability
the 'OK' was proposed to be renamed to 'Open in Imagej'
the
ENTERkey was registered with this button