Fix a bug with empty factors #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a factor has been defined but evaluates to "False" (e.g. an empty body), this factor would be skipped during the compare phase. This commit changes the behaviour to use "None" as a placeholder instead of every False-ish value.
|
Thank you very much for spotting and fixing this <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a bug where the web server would reply with an empty body on the probe request, but with a body if a certain parameter was specified. Arjun failed to recognize this, because the probe-phase set
factors['same_body']to an empty string.During comparison, this would then be evaluated to
Falseand the body-comparison would be skipped.This commit fixes this bug by using the explicit
Nonevalue as the "skip" placeholder.