Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] main: refactor the entry function to make it more readable #210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0xSaltyHash
Copy link

Good Day.

I am a long time user of your tool and wanted to give back by contributing to making it better, so while browsing the codebase I noticed that some functions and files requires some refactoring and modifications to increase code readability and make it more clear.

So I decided to give it a try, and decided to start with the entry point and its supporting functions.

This pull request introduces a rework of the entry main function and prepare_request method:

  • Ensures that the prepare request returns the same datatype across all types, here it is always list.
  • Modify the docstring of these supporting functions to reflect the new return datatype
  • Unify the flow of code between single and multi URL parsing this reduced complexity and removed deep nesting within the body of the method.

If you welcome more contributions of this kind I'd be happy to invest more time on it, if not please feel free to close the pull request and I will respect your decision as the maintainer and creator of this tool.

@s0md3v
Copy link
Owner

s0md3v commented Apr 17, 2024

Hi @0xSaltyHash ,

Thank you for your contribution. It will take me some time for me to review this but I really appreciate the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants