Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parsing multiple arg tokens #22

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

FrankReh
Copy link
Contributor

The Comma token needs to be popped in order to move the logic forward and let the loop work on the next token.

The `Comma` token needs to be popped in order to move the logic
forward and let the loop work on the next token.
@FrankReh
Copy link
Contributor Author

When I tried running the exported 'add' function from the "add.wasm" file found in https://github.com/bytecodealliance/component-docs/tree/main/component-model/examples/example-host
the second argument, already having been tokenized, was not being picked up properly by the loop in question.

Popping the Comma token fixed things up and I was able to use the Wasm Component REPL to add to integers together.

@FrankReh
Copy link
Contributor Author

I guess waiting for your merge?

@rylev rylev merged commit 5c461b3 into rylev:main Apr 29, 2024
1 check passed
@FrankReh FrankReh deleted the fix-multiple-args branch April 29, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants