Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Add a possibility to wire a health check executor #92

Open
wants to merge 1 commit into
base: v3.0-maintenance
Choose a base branch
from

Conversation

victorbr
Copy link

Add an option to wire in an executor service for health checks

@ryantenney
Copy link
Owner

I don't want to autowire the executor, especially without a qualifier. How about removing @Autowired and adding a setter so one can be manually wired in?

@victorbr
Copy link
Author

Took me some time to recall the context since it's been some 8 months...
You're right, @Autowired is not a good choice here. In our local code we ended up using @Resource.
I'm not sure though how your suggestion would work. If I'm not mistaken the instance of the class is created by the container and not by Spring. So where would the manual wiring take place?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants