This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
V4.02 DropWizard Support #220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikebell90
commented
Oct 30, 2018
|
|
||
| ```xml | ||
| <dependency> | ||
| <groupId>com.ryantenney.metrics</groupId> | ||
| <artifactId>metrics-spring</artifactId> | ||
| <version>3.1.3</version> | ||
| <version>3.9.9</version> |
There was a problem hiding this comment.
I haven't made this 4.0.0 yet, pending an official merge
mikebell90
commented
Oct 30, 2018
| <version>3.1.3-SNAPSHOT</version> | ||
| <packaging>bundle</packaging> | ||
| <version>3.9.9-SNAPSHOT</version> | ||
| <packaging>jar</packaging> |
There was a problem hiding this comment.
I'm not too familiar with the osgi stuff, and it was giving odd errors, but can restore
There was a problem hiding this comment.
The bundle packaging didn't seem to work, haven't investigated
mikebell90
commented
Oct 30, 2018
| @@ -56,22 +56,25 @@ | |||
| </repository> | |||
| </repositories> | |||
| <properties> | |||
| <maven.compiler.source>1.8</maven.compiler.source> | |||
There was a problem hiding this comment.
Can drop this down if desired, but I think nowadays this is a reasonable baseline
mikebell90
commented
Oct 30, 2018
| @@ -225,7 +228,7 @@ | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>io.dropwizard.metrics</groupId> | |||
| <artifactId>metrics-ganglia</artifactId> | |||
| <artifactId>metrics-jmx</artifactId> | |||
| <optional>true</optional> | |||
There was a problem hiding this comment.
On retrospect this probably shouldn't be optional.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expansion of #217 . Still needs extensive testing