This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Support for meta-annotations #163 #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a good starting point for enabling meta annotations. There are 2 tests (CovariantReturnTypeTest + MeteredInterfaceTest) that will break because annotations at interface level will now be taken into consideration. I think this should be the correct behaviour because the codahale annotations are marked with Inherited.
I added a test (MetaAnnotationTest). The Counted annotation has no support for element type ANNOTATION_TYPE. So there is no test for that case. I do not understand why the annotation from codahale is not used in the CountedMethodInterceptor. Why does your Counted annotation exist?