Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Update user documentation #1717

Merged
merged 5 commits into from
May 27, 2024
Merged

Conversation

friendlyAce
Copy link
Contributor

@friendlyAce friendlyAce commented Apr 25, 2024

Fixed typos

@github-actions github-actions bot added the 📚 Docs Web Documentation hosted on github pages label Apr 25, 2024
Copy link
Member

@hoebbelsB hoebbelsB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @friendlyAce for the contribution <3

@friendlyAce
Copy link
Contributor Author

I'm not familiar with nx format and this build environment, but the action fails on checking the format https://cloud.nx.app/runs/GJdZDnw0SK

Running format:write locally, formats the 2 markdowns that i have changed very poorly

$ nx format:check
apps/docs/docs/cdk/render-strategies/strategies/concurrent-strategies.md
apps/docs/docs/template/api/unpatch-directive.md
error Command failed with exit code 1.
$ nx format:write
apps/docs/docs/cdk/render-strategies/strategies/concurrent-strategies.md
apps/docs/docs/template/api/unpatch-directive.md
Done in 1.24s.

image

@friendlyAce friendlyAce changed the title fix(docs) Update concurrent-strategies.md fix(docs): Update user documentation Apr 27, 2024
@hoebbelsB
Copy link
Member

hey @friendlyAce it's again the format:check command failing: https://cloud.nx.app/runs/MUI7qGE6Ge/task/nx-cloud-tasks-runner%3Arecord-command

You can fix it by executing yarn nx format:write

@hoebbelsB hoebbelsB merged commit 24cdc8f into rx-angular:main May 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 Docs Web Documentation hosted on github pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants