Skip to content

Commit

Permalink
refactor(cdk): drop unused scheduler APIs
Browse files Browse the repository at this point in the history
  • Loading branch information
edbzn committed May 23, 2024
1 parent 117f30c commit ce1cdea
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 227 deletions.
67 changes: 8 additions & 59 deletions libs/cdk/internals/scheduler/src/lib/scheduler.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ describe('Scheduler', () => {

const NormalPriority = 3;
let scheduleCallback: typeof import('./scheduler').scheduleCallback;
let requestPaint: typeof import('./scheduler').requestPaint;
let cancelCallback: typeof import('./scheduler').cancelCallback;
let shouldYield: typeof import('./scheduler').shouldYield;

describe.each([['Browser'], ['Node'], ['NonBrowser']])('%p', (env) => {
beforeEach(() => {
Expand All @@ -43,9 +41,7 @@ describe('Scheduler', () => {
// eslint-disable-next-line @typescript-eslint/no-var-requires
const Scheduler = require('./scheduler');
scheduleCallback = Scheduler.scheduleCallback;
requestPaint = Scheduler.requestPaint;
cancelCallback = Scheduler.cancelCallback;
shouldYield = Scheduler.shouldYield;
});

afterEach(() => {
Expand Down Expand Up @@ -74,33 +70,6 @@ describe('Scheduler', () => {
runtime.assertLog([LogEvent.MessageEvent, LogEvent.Task]);
});

it('task with continuation', () => {
let now: number;
scheduleCallback(NormalPriority, () => {
runtime.log(LogEvent.Task);
while (!shouldYield()) {
runtime.advanceTime(1);
}
now = performance.now();
runtime.log(`Yield at ${now}ms`);
return () => {
runtime.log(LogEvent.Continuation);
};
});
runtime.assertLog([schedulingMessageEvent]);

runtime.fireMessageEvent();
runtime.assertLog([
LogEvent.MessageEvent,
LogEvent.Task,
`Yield at ${now}ms`,
schedulingMessageEvent,
]);

runtime.fireMessageEvent();
runtime.assertLog([LogEvent.MessageEvent, LogEvent.Continuation]);
});

it('multiple tasks', () => {
scheduleCallback(NormalPriority, () => {
runtime.log('A');
Expand All @@ -113,26 +82,6 @@ describe('Scheduler', () => {
runtime.assertLog([LogEvent.MessageEvent, 'A', 'B']);
});

it('request paint ', () => {
scheduleCallback(NormalPriority, () => {
runtime.log('A');
requestPaint();
});
scheduleCallback(NormalPriority, () => {
runtime.log('B');
});
runtime.assertLog([schedulingMessageEvent]);
runtime.fireMessageEvent();
runtime.assertLog([
LogEvent.MessageEvent,
'A',
// A forced paint
schedulingMessageEvent,
]);
runtime.fireMessageEvent();
runtime.assertLog([LogEvent.MessageEvent, 'B']);
});

it('multiple tasks with a yield in between', () => {
scheduleCallback(NormalPriority, () => {
runtime.log('A');
Expand Down Expand Up @@ -227,7 +176,7 @@ describe('Scheduler', () => {
() => {
runtime.log('A');
},
{ ngZone }
{ ngZone },
);
runtime.assertLog([schedulingMessageEvent]);
runtime.fireMessageEvent();
Expand All @@ -243,21 +192,21 @@ describe('Scheduler', () => {
() => {
runtime.log('A');
},
{ ngZone }
{ ngZone },
);
scheduleCallback(
NormalPriority,
() => {
runtime.log('B');
},
{ ngZone: ngZone2 }
{ ngZone: ngZone2 },
);
scheduleCallback(
NormalPriority,
() => {
runtime.log('C');
},
{ ngZone: ngZone }
{ ngZone: ngZone },
);
runtime.assertLog([schedulingMessageEvent]);
runtime.fireMessageEvent();
Expand All @@ -274,22 +223,22 @@ describe('Scheduler', () => {
() => {
runtime.log('A');
},
{ ngZone }
{ ngZone },
);
scheduleCallback(
NormalPriority,
() => {
runtime.log('B');
runtime.advanceTime(4000);
},
{ ngZone: ngZone2 }
{ ngZone: ngZone2 },
);
scheduleCallback(
NormalPriority,
() => {
runtime.log('C');
},
{ ngZone }
{ ngZone },
);
runtime.assertLog([schedulingMessageEvent]);
runtime.fireMessageEvent();
Expand Down Expand Up @@ -322,7 +271,7 @@ describe('Scheduler', () => {
() => {
runtime.log('A');
},
{ ngZone }
{ ngZone },
);
runtime.assertLog([schedulingMessageEvent]);
runtime.fireMessageEvent();
Expand Down
Loading

0 comments on commit ce1cdea

Please sign in to comment.