Add -a, --all flag to garbage command #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And extend tests accordingly Relates to rustwasm#109
data-pup
reviewed
Aug 13, 2018
| } | ||
|
|
||
| /// Set the maximum number of items to display. | ||
| pub fn set_max_items(&mut self, max: u32) { | ||
| self.max_items = max; | ||
| self.all_items = false; |
data-pup
reviewed
Aug 13, 2018
| "json", | ||
| "-a" | ||
| ); | ||
|
|
There was a problem hiding this comment.
Nice job adding these tests as well!
There was a problem hiding this comment.
Testing is the most important ;)
data-pup
approved these changes
Aug 13, 2018
|
LGTM! Nice work @userzimmermann! 😸 I see you've also started out on #120, that's awesome! Unless @fitzgen has any other input, I think this can be merged. |
If it gets your approval stamp, that is all I need to know :) |
|
Thx for nice feedback @data-pup @fitzgen! And approving, merging, etc :) Just right after you merged, it came to my mind that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And here it is: The first
--allflag according to #109 :)I also added some new
twiggy garbagetests for the new flag, based onfixtures/wee_alloc.wasm, sincefixtures/garbage.wasmunfortunately only produces 9 items, but-n <max_items>defaults to10:D