Android: Somewhat align scancode conversions with Firefox #4023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox' source at: https://searchfox.org/mozilla-central/rev/c597e9c789ad36af84a0370d395be066b7dc94f4/widget/NativeKeyToDOMCodeName.h Seems to use some other form of scan code? So instead we try to map as many of the codes available on `Keycode` that they do as possible.
madsmtm
force-pushed
the
madsmtm/android-scancode-firefox
branch
from
b538cef to
27840eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #4019, but for Android, and only for the Firefox sources (haven't gone through Chromium's sources for this kind of stuff yet).
Firefox' sources seems to use some other form of scan code that I couldn't figure out? So instead we try to map as many of the codes available on
Keycodethat they do as possible.changelogmodule if knowledge of this change could be valuable to users