Move Fullscreen enum into platforms
#3901
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
requested review from
jackpot51,
notgull,
daxpedda,
kchibisov and
MarijnS95
as code owners
madsmtm
force-pushed
the
madsmtm/refactor-fullscreen
branch
from
7f5f677 to
eec1774
Compare
Needed if we intend to split these into separate crates.
madsmtm
force-pushed
the
madsmtm/refactor-fullscreen
branch
from
eec1774 to
82b5aa1
Compare
MarijnS95
reviewed
Sep 11, 2024
Comment on lines
+1009
to
+1010
| #[derive(Clone, Debug, PartialEq, Eq)] | ||
| pub enum Fullscreen { |
There was a problem hiding this comment.
How does this work if the functions implementing the API for this (that take or return the Fullscreen type) are defined by a core trait?
In any case, on Android we can remove this entirely because it's "not implemented" and not entirely sane to implement.
kchibisov
requested changes
Sep 11, 2024
We don't actually want to convert though, we want to use the exact same thing on the top type as well, like for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of duplication, but needed if we intend to split the backends into separate crates, since we need to convert between the root crate's
VideoModeHandleandMonitorHandles, and the platform's types.