Port Project Keter's test runner to this project #3
Conversation
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
There was a problem hiding this comment.
I haven't looked into how it actually works, but in general, you shouldn't touch winit-core. You should test the winit stuff, the core is irrelevant?
It'll also be nice to have some sort of CI for stuff like that to actually see how it could be used and what we can achieve with that.
Given that it doesn't interact with the winit stuff itself yet it could leave on this branch for now unless we have it actually wired with real tests on platforms supporting that, if it's fine with you.
| use futures_lite::future::block_on; | ||
|
|
||
| #[allow(clippy::eq_op)] | ||
| fn main() { | ||
| winit_test::run_tests(|harness| { | ||
| block_on(async move { | ||
| harness.test("hello world", async { | ||
| assert_eq!(1 + 1, 2) | ||
| }).await; | ||
| }); |
There was a problem hiding this comment.
Do we really need any tests here? This doesn't have any core logic stuff it should all go into the winit crate instead.
|
Is this capable of running integration tests on Winit? E.g. resizing a window and checking if the correct events are fired? |
|
Not yet; it's just a test runner for now |
As discussed in chat, ports the test framework I wrote for testing Project Keter to winit. Hopefully useful for making sure everything works in CI.
Not really CI-ready yet. I need to upload all of the Docker images first.