Allow passing index as :ident in set_general_handler macro #384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, please consider this small QOL change to the set_general_handler macro.
This would allow the index to be specified by a const or variable e.g.
instead of being forced to convert it to a range
I'm not sure if there's any way to make this change less repetitive by having
$idx
be either literal or ident. It might also be worth considering refactoring out the setting individual handler functionality (the$idx
variants) into its own macro and allow users to pass a$range:ident
to the current macro to avoid ambiguity.