Prepare 1.28.0 release #4079
Prepare 1.28.0 release #4079
Conversation
|
Also Line 36 in c8eddcb |
@ChrisDenton Thanks for pointing it out! That's part of the plan, yeah, but it cannot be done in this PR for technical reasons. (It should be done right after this PR though.) |
Do you mean the addition of Chris to the team? If there are other things you'd like to add, now would be a good time to mention that, I think? |
djc
force-pushed
the
prepare-1.28.0
branch
2 times, most recently
from
adb19a5
to
07bdcf7
Compare
Addressed the issues you've mentioned so far! |
|
|
||
| - The default download backend has been changed from reqwest with native-tls to reqwest with rustls. [pr#3798] | ||
| - `RUSTUP_USE_CURL` and `RUSTUP_USE_RUSTLS` can still be used to change the download backend | ||
| if the new backend causes issues. If issues do happen, please [let us know](https://github.com/rust-lang/rustup/issues/3806). |
There was a problem hiding this comment.
This might not be a significant point. However, we(at least recent three releases) usually prefer placing all links at the end of the document. For example:
[let us know]: #3806
I simply followed the format used in previous changelog sections. That said, I think it's acceptable to have two different styles coexisting.
There was a problem hiding this comment.
placing all links at the end of the document
I second this, despite the fact that this PR tries to maximally utilize the GitHub-generated detailed changelog. For the "manual" part, at least, it'd still be better to simply follow the established convention.
@djc That has been all. Thanks a lot! If anything happens, we can still modify the changelog during the beta testing period :) |
This is the 1st PR for the
1.28.0release according to our release process.Checklist
Draft the release blog post(Not required, since we're doing a beta release).