defrost RUST_MIN_STACK=ice rustc hello.rs
#125302
Merged
+46
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An earlier commit included the change for a suggestion here. Unfortunately, it also used unwrap instead of dying properly. Roll out the ~~rice paper~~ EarlyDiagCtxt before we do anything that might leave a mess.
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
rustbot
added
S-waiting-on-review
|
Thanks @danielhenrymantilla! |
compiler-errors
approved these changes
May 20, 2024
compiler/rustc_interface/src/util.rs
Outdated
| .map(|s| { | ||
| s.trim().parse::<usize>().unwrap_or_else(|_| { | ||
| #[allow(rustc::untranslatable_diagnostic)] | ||
| early_dcx.early_fatal("`RUST_MIN_STACK` should be unset or a number of bytes") |
There was a problem hiding this comment.
Suggested change
| early_dcx.early_fatal("`RUST_MIN_STACK` should be unset or a number of bytes") | |
| early_dcx.early_struct_fatal(format!("`RUST_MIN_STACK` be set to a number of bytes, but it was set to `{}`", s.trim())).note("alternatively, unset `RUST_MIN_STACK` if it was not meant to be set").emit() |
There was a problem hiding this comment.
an idea (modulo formatting) to make the note more descriptive
don't particularly care if it's done with this exact primary/note, but specifically, i'd like for us to explain to the user what was set for RUST_MIN_STACK, so it's easier for them to (e.g.) search through a bash file or an env file to see where it's set incorrectly.
workingjubilee
force-pushed
the
prefer-my-stack-neat
branch
from
569c1de
to
b6d0d6d
Compare
compiler-errors
approved these changes
May 20, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
r? compiler-errors |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 20, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#125034 (Weekly `cargo update`) - rust-lang#125093 (Add `fn into_raw_with_allocator` to Rc/Arc/Weak.) - rust-lang#125282 (Never type unsafe lint improvements) - rust-lang#125301 (fix suggestion in E0373 for !Unpin coroutines) - rust-lang#125302 (defrost `RUST_MIN_STACK=ice rustc hello.rs`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 20, 2024
Rollup merge of rust-lang#125302 - workingjubilee:prefer-my-stack-neat, r=compiler-errors defrost `RUST_MIN_STACK=ice rustc hello.rs` I didn't think too hard about testing my previous PR rust-lang#122847 which makes our stack overflow handler assist people in discovering the `RUST_MIN_STACK` variable (which apparently is surprisingly useful for Really Big codebases). After it was merged, some useful comments left in a drive-by review led me to discover I had added an ICE. This reworks the code a bit to explain the rationale, remove the ICE that I introduced, and properly test one of the diagnostics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't think too hard about testing my previous PR #122847 which makes our stack overflow handler assist people in discovering the
RUST_MIN_STACKvariable (which apparently is surprisingly useful for Really Big codebases). After it was merged, some useful comments left in a drive-by review led me to discover I had added an ICE. This reworks the code a bit to explain the rationale, remove the ICE that I introduced, and properly test one of the diagnostics.