Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greatly speed up doctests by compiling compatible doctests in one file #123974

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Greatly speed up doctests by compiling compatible doctests in one file #123974

wants to merge 24 commits into from
+1,397 −432

Commits on May 18, 2024

  1. Clean up rustdoc make_test function code

    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    86833ee View commit details
    Browse the repository at this point in the history

  2. Create DocTest type to handle generation of doctests

    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    587c522 View commit details
    Browse the repository at this point in the history

  3. Split doctests into categories

    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    4867760 View commit details
    Browse the repository at this point in the history

  4. Compile all (compatible) doctests as one

    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    78171c6 View commit details
    Browse the repository at this point in the history

  5. Remove ignore_to_bool function

    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    e022387 View commit details
    Browse the repository at this point in the history

  6. Set ignore value directly into make_test

    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    cce04bb View commit details
    Browse the repository at this point in the history

  7. Add fallback in case the "all in one" doctests failed to compile

    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    b8f0f2c View commit details
    Browse the repository at this point in the history

  8. Create DocTestInfo to improve API of run_test

    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    56acb5d View commit details
    Browse the repository at this point in the history

  9. Correctly handle test args and move ignored doctests into the one file

    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    882d119 View commit details
    Browse the repository at this point in the history

  10. Fix case where AST failed to parse to give better errors

    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    45b075f View commit details
    Browse the repository at this point in the history

  11. Correctly handle exit status

    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    cdb59a1 View commit details
    Browse the repository at this point in the history

  12. Bless rustdoc ui tests

    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    e6f38c5 View commit details
    Browse the repository at this point in the history

  13. Run doctests by batches instead of running them all at once when ther… 

    …e are too many
    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    2c27d9c View commit details
    Browse the repository at this point in the history

  14. Don't set test_harness to true by default as it would generate in… 

    …valid code for combined doctests
    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    76f70fa View commit details
    Browse the repository at this point in the history

  15. Ignore test using link which creates segfault

    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    f235cbf View commit details
    Browse the repository at this point in the history

  16. Improve handling of --persist-doctests with combined doctests and u… 

    …pdate associated test to check both combined and non-combined doctests
    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    b5ca844 View commit details
    Browse the repository at this point in the history

  17. Run merged doctests as one instead of using batches

    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    e4b74f4 View commit details
    Browse the repository at this point in the history

  18. Allow to merge doctests only starting the 2024 edition

    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    7ea8909 View commit details
    Browse the repository at this point in the history

  19. Add standalone doctest attribute

    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    5a3d239 View commit details
    Browse the repository at this point in the history

  20. Add documentation for the doctest standalone attribute

    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    847664a View commit details
    Browse the repository at this point in the history

  21. Improve code

    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    24a23e1 View commit details
    Browse the repository at this point in the history

  22. Improve code and rustdoc book

    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    88cbb78 View commit details
    Browse the repository at this point in the history

  23. Add equivalent of rustdoc-ui test failed-doctest-should-panic for t… 

    …he 2021 edition
    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    222f7dc View commit details
    Browse the repository at this point in the history

  24. If there is any AST error with a doctest, we make it a standalone test 

    To do so, AST error detection was improved in order to not filter out
too many doctests.
    @GuillaumeGomez
    GuillaumeGomez committed May 18, 2024
    Configuration menu
    Copy the full SHA
    2e3c2aa View commit details
    Browse the repository at this point in the history