nicer style rules for margin around footnote defs #2524
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous implementation used
:not(.footnote-definition) + .footnote-definition
and.footnote-definition + :not(.footnote-definition)
.the latter selector caused many problems:
this PR replaces the latter selector with
:not(:has(+ .fd))
, which fixes all of the mentioned problems.see rust-lang/reference@bc02bf9 for concrete motivation.
See https://caniuse.com/mdn-css_selectors_not and https://caniuse.com/css-has for comparison of browser support of
:not
and:has
(:has
is slightly worse).cc @ehuss