Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Use ember-asset-size-action to report asset size changes to PRs #2410

Closed
wants to merge 2 commits into from

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Apr 10, 2020

r? @locks

@github-actions
Copy link

Files that stayed the same size 🤷‍:

File raw gzip
auto-import-fastboot.js 0 B 0 B
cargo-fastboot.js 0 B 0 B
cargo.js 0 B 0 B
vendor.js 0 B 0 B
cargo.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

Files that got Smaller 🎉:

File raw gzip
cargo.js -12.9 kB -1.44 kB

Files that stayed the same size 🤷‍:

File raw gzip
auto-import-fastboot.js 0 B 0 B
cargo-fastboot.js 0 B 0 B
vendor.js 0 B 0 B
cargo.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Apr 10, 2020

Size Change: -1.17 MB (399%) 🏆

Total Size: 292 kB

Filename Size Change
dist/assets/cargo-fastboot.js 3.1 kB -521 B (16%) 👏
dist/assets/cargo.css 5.95 kB -1.32 kB (22%) 🎉
dist/assets/cargo.js 39.3 kB -24.4 kB (61%) 🏆
dist/assets/test-support.css 0 B -2.37 kB (0%)
dist/assets/test-support.js 0 B -154 kB (0%)
dist/assets/tests.js 0 B -17.3 kB (0%)
dist/assets/vendor.css 1.66 kB -1.37 kB (82%) 🏆
dist/assets/vendor.js 241 kB -840 kB (347%) 🏆
dist/ember-fetch/fetch-fastboot.js 510 B -596 B (116%) 🏆
dist/ember-svg-jar/static/css/main.f3aef49e.chunk.css 0 B -4.55 kB (0%)
dist/ember-svg-jar/static/js/2.ced0fc45.chunk.js 0 B -107 kB (0%)
dist/ember-svg-jar/static/js/main.0e7a56b1.chunk.js 0 B -13.7 kB (0%)
dist/ember-svg-jar/static/js/runtime~main.a8a9905a.js 0 B -762 B (0%)
dist/moment/fastboot-moment-timezone.js 131 B -28 B (21%) 🎉
dist/moment/fastboot-moment.js 122 B -32 B (26%) 🎉
dist/testem.js 0 B -381 B (0%)
ℹ️ View Unchanged
Filename Size Change
dist/assets/auto-import-fastboot.js 20 B 0 B

compressed-size-action

@locks
Copy link
Contributor

locks commented Apr 11, 2020

What happened to the application template?

@Turbo87
Copy link
Member Author

Turbo87 commented Apr 11, 2020

@locks I needed to delete something so that this PR actually shows a filesize diff 😉

@Turbo87 Turbo87 force-pushed the asset-size branch 2 times, most recently from 464d046 to 87720e0 Compare April 11, 2020 18:42
@Turbo87
Copy link
Member Author

Turbo87 commented Apr 11, 2020

given preactjs/compressed-size-action#2, I guess this is not as useful as I hoped it would be :-/

@Turbo87 Turbo87 closed this Apr 11, 2020
@Turbo87 Turbo87 deleted the asset-size branch April 19, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants