Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: fix(config): Improve the error for partial-struct #13694

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

WIP: fix(config): Improve the error for partial-struct #13694

wants to merge 2 commits into from

Conversation

epage
Copy link
Contributor

@epage epage commented Apr 2, 2024

What does this PR try to resolve?

Fixes #13688

How should we test and review this PR?

Additional information

@epage epage marked this pull request as draft April 2, 2024 21:55
@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2024

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-configuration Area: cargo config files and env vars S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2024
@epage epage mentioned this pull request Apr 2, 2024
Open
weihanglo
weihanglo reviewed Apr 2, 2024
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be be possible to have definition information included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@weihanglo weihanglo

Labels
A-configuration Area: cargo config files and env vars S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unhelpful error messages with env-vars that don't set all fields of a config struct
3 participants
@epage @rustbot @weihanglo