Help with ambiguity about 'static lifetimes #4161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! See also #4067. I’ll be trying to integrate these two PRs together (possibly taking ideas from both and rewriting them!), because there’s clearly a bit of a phrasing issue here, and I agree that we should fix it! |
|
Ah, I somehow missed the existing PR. Regardless, thank you! |
|
No worries – thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first sentence of this paragraph tripped me up for a minute when reading today. At first pass, I had trouble parsing it because I was wondering a couple of things:
'staticlifetimes in error messages?This is my attempt to make this paragraph more readable--hopefully without being too verbose.
I only changed the first sentence and the first word of the second sentence.