Fix minor grammatical error #4098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The antecedent of "that" in this context is "places", not "one", so it is plural.
chriskrycho
reviewed
Nov 25, 2024
There was a problem hiding this comment.
I have been mulling on this for a couple weeks and I think we’d be better to go with “with” here, actually:
one of the few places in Rust with this behavior.
That will dodge the issue entirely (people will get tripped up reading it either way). Mind making that tweak and then we can merge it?
chriskrycho
reviewed
Dec 18, 2024
Which verb tense matches? Make it so we don’t have to care!
chriskrycho
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extreme nitpick, very low priority: the antecedent of "that" in this context is "places", not "one", so it is plural.