Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the reason more understandable #4074

Merged
merged 3 commits into from
Dec 12, 2024
Merged

fix: make the reason more understandable #4074

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26f571b
fix: make the reason more understandable
spotlesscoder Oct 16, 2024
66ef2b6
Merge branch 'main' into patch-1
spotlesscoder Dec 12, 2024
addb9e1
Update src/ch04-03-slices.md for formatting
chriskrycho Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/ch04-03-slices.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,12 @@ slices, to understand the problem that slices will solve:
fn first_word(s: &String) -> ?
```

The `first_word` function has a `&String` as a parameter. We don’t want
ownership, so this is fine. But what should we return? We don’t really have a
way to talk about _part_ of a string. However, we could return the index of the
end of the word, indicated by a space. Let’s try that, as shown in Listing 4-7.
The first_word function has a &String as a parameter. We don’t need ownership, so this is fine.
(In idiomatic Rust, functions do not take ownership of their arguments unless they need to,
and the reasons for that will become clear as we keep going!)
But what should we return? We don’t really have a way to talk about part of a string.
However, we could return the index of the end of the word, indicated by a space.
Let’s try that, as shown in Listing 4-7.
chriskrycho marked this conversation as resolved.
Show resolved Hide resolved

<Listing number="4-7" file-name="src/main.rs" caption="The `first_word` function that returns a byte index value into the `String` parameter">

Expand Down
Loading