Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ch07-02-defining-modules-to-control-scope-and-privacy.md #3801

Closed
wants to merge 1 commit into from

Conversation

0xSaksham
Copy link

I found some grammar errors while reading the book and a ( , ) comma missing making it hard to interpret what message the author was trying to convey.

I found some grammar errors while reading the book and a ( , ) comma missing making it hard to interpret what message the author was trying to convey.
Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! As it turns out, the original text here is either more correct or at least as correct as the suggested changes, although you might have to read some of the passages carefully to see why that is so. I am going to go ahead close this accordingly. We appreciate your caring about this level of detail, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants