Clarification of let variables declarations #3453
Closed
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change made to make it clear that let variables cannot be declared in the global scope. This small addition makes it more explicitly clear. It's one of the questions asked in the follow along quiz version of the book and while following along it wasn't made clear until a question was asked. I think having it explicitly stated in the book will be helpful.
improved the wording
chriskrycho
reviewed
Nov 25, 2024
There was a problem hiding this comment.
Thanks for the suggestion. As I look at this, though, I think the text is fine as is: although the contrast with let is implicit, not explicit, that’s okay. The book is not a reference, and neither can nor should cover every single detail. If someone is curious, they can always try writing a let binding in module scope, and the compiler will tell them in a friendly way that it is not allowed (as in this playground, for example):
consider using
constorstaticinstead ofletfor global variables
Net, I think it’s best to go ahead and leave this as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-worded part of the explaining the differences between const and let variables to make it explicitly clear that let variables cannot be declared in the global scope.