-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt SVGs to book theme #3277
base: main
Are you sure you want to change the base?
Adapt SVGs to book theme #3277
Conversation
@ericthelemur Any progress on this? |
I haven't looked at this for a while now, but I think it's still correct and complete. This solution has continued to worked well on my own mdbook. The only downside is having to inline svgs. I'll rebase it to current and check it is still valid |
35ed7a4
to
5115371
Compare
This seems excellent; I’ll resolve the conflicts and get it integrated. Thank you! |
Ah, addendum: I will think about how to get this landed as well—I don’t think this will work directly with the existing pathway for generating the SVGs using Graphviz. That may be fine, depending on how we want to proceed with these going forward (we are not editing them all the time or anything, after all!), but it does commit us at least somewhat to working with them either directly as XML or using a dedicated app for editing them. |
This issue has been discussed in #74, and I've described my approach there. The idea is to
#include
the SVGs (avoiding Markdown formatting) and use existing CSS variables to match the theme.This will fall back to the original black and white if the CSS variables are unavailable.
Example in context: