Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt SVGs to book theme #3277

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ericthelemur
Copy link

@ericthelemur ericthelemur commented Jul 24, 2022

This issue has been discussed in #74, and I've described my approach there. The idea is to #include the SVGs (avoiding Markdown formatting) and use existing CSS variables to match the theme.

This will fall back to the original black and white if the CSS variables are unavailable.

Example in context:

@carols10cents carols10cents added this to the all milestone Jul 31, 2022
@wasd96040501
Copy link

@ericthelemur Any progress on this?

@ericthelemur
Copy link
Author

I haven't looked at this for a while now, but I think it's still correct and complete. This solution has continued to worked well on my own mdbook. The only downside is having to inline svgs.

I'll rebase it to current and check it is still valid

@ericthelemur ericthelemur marked this pull request as ready for review September 5, 2023 13:05
@chriskrycho
Copy link
Contributor

This seems excellent; I’ll resolve the conflicts and get it integrated. Thank you!

@chriskrycho
Copy link
Contributor

Ah, addendum: I will think about how to get this landed as well—I don’t think this will work directly with the existing pathway for generating the SVGs using Graphviz. That may be fine, depending on how we want to proceed with these going forward (we are not editing them all the time or anything, after all!), but it does commit us at least somewhat to working with them either directly as XML or using a dedicated app for editing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants