Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add submitpackage #302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add submitpackage #302

wants to merge 1 commit into from

Conversation

joostjager
Copy link

No description provided.

stevenroose
stevenroose requested changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@stevenroose stevenroose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, just nits.

I can't find a reference for the submitpackage rpc.. Is there an MR that adds it?

Could you add an integration test as well?

Thanks!

json/src/lib.rs Outdated Show resolved Hide resolved
json/src/lib.rs Outdated Show resolved Hide resolved
client/src/client.rs Outdated Show resolved Hide resolved
@joostjager
Copy link
Author

I can't find a reference for the submitpackage rpc.. Is there an MR that adds it?

It was added in bitcoin/bitcoin#24836. Regtest only, but possibly enabled for all networks in 25.0.

@joostjager
Copy link
Author

joostjager commented May 15, 2023 •
edited
Loading

Could you add an integration test as well?

Seems blocked on #297

@tcharding tcharding added this to the v0.20.0 milestone Apr 30, 2024
@jlest01 jlest01 mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenroose stevenroose stevenroose requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@joostjager @stevenroose @tcharding